Welcome to the AFK Mods bug tracker. In order to report an issue, you need to have a VALIDATED account to post one. Once you have followed the link the registration email sent you, please select a project from the drop down menu below. Select “Open New Issue” and fill out the form with as many details as possible.

Please also consider sending your bug report to Bethesda if you are reporting on an issue with Skyrim Special Edition, Fallout 4, or Starfield. Doing so will help everyone on all platforms.

Issue Data
Status: Closed
Issue Type: Bug Report
Project: Unofficial Skyrim Legendary Edition Patch
Component: Skyrim LE: Vanilla
Category: Quests
Assigned To: Nobody
Platform: Windows PC
Severity: Low
Votes: 0
Watching: N/A
Opened By DayDreamer on Apr 19, 2014 2:58 am
Closed By Arthmoor on Apr 21, 2014 1:03 am
Resolution: Fixed

Issue #15396: DialogueRiften condition errors

 
DialogueRiftenKeeravaRumorsBranch, somebody copied them all testing pDia04, and then forgot to change to the actually appropriate test.

pDia04 enables DialogueRiftenRatwayBranch topics. While it would have been nicer to use descriptive names, it's too late to change now.

For example, "The Thieves Guild has been pushing hard ..." shouldn't be conditioned on prior mentions of "Ratway", instead that should be pDia09 that in turn enables DialogueRiftenThievesGuildBranch topics.

Another example, "Mjoll the Lioness used to adventure across Skyrim ..." shouldn't be conditioned on prior mentions of "Ratway". (I haven't yet figured out the correct flag, it's painful reverse engineering.)

Related Issues: 29332  

Comments

8 comment(s) [Closed]
DayDreamer said:
 
So far, I've identified:

.pDia01 DialogueRiftenBersi*<br>
.pDia02 DialogueRiftenHarrald*<br>
.pDia03 DialogueRiftenSaerlund*<br>
.pDia04 DialogueRiftenRatway*<br>
.pDia05 DialogueRiftenBrandShei*<br>
.pDia06 DialogueRiftenGrelka*
.pDia07 -&gt; DialogueRiftenBlackBriar*<br>
.pDia08 DialogueRiftenLailaBranchInPower<br>
.pDia09 DialogueRiftenThievesGuild*<br>
.pDia10 DialogueRiftenTalenJeiDrinkBranchTopic
.pDia11 DialogueRiftenSnowShodHatredTopic
.pDia12 DialogueRiftenAsgeir*
.pDia13 DialogueRiftenBolli*
.pDia14 FFRiften12WujeetaBranchTopic -&gt; DialogueRiftenSkoomaBranchTopic
.pDia15 DialogueRiftenAlessandra*<br>
.pDia16 DialogueRiftenMjoll*<br>
.pDia17 DialogueRiftenMolgrom*<br>
.pDia18 -&gt; DialogueRiftenMadesiSaxhleelBranchTopic<br>
.pDia19 DialogueRiftenNuraTalos -&gt; DialogueRiftenSnowShodHatredTopic
.pDia20 DialogueRiftenSvana*
.pDia21 DialogueRiftenDirge*
.pDia22 DialogueRiftenAnurielJobBranchTopic (Anuriel)
.pDia23 DialogueRiftenAnurielJobBranchTopic (Hemming)
.pDia24 DialogueRiftenHemming*

Comment #1 Apr 19, 2014 4:45 am
DayDreamer said:
 
18 isn't set, but should be set in FFRiften18, where he mentions Saxhleel jewelry. This repair will give us a few never-before-heard lines!

07 isn't set, <strike>and I have not found anywhere it is used,</strike> so I'm hijacking it for Keerava to condition her Black-Briar lines. <strike>It may cause more new things to appear elsewhere, but I'm not able to figure out a TES5Edit script for finding VM variables in conditions (yet).</strike>

Needless to say, Keerava shouldn't condition her rumors about dragons, skooma, or anything else on pDia04 Ratway. I've applied the above flag discoveries to replace it.

Comment #2 Apr 19, 2014 1:38 pm
DayDreamer said:
 
Half of the pDia04 DialogueRiftenRatway* are by actors that also have pDia09 DialogueRiftenThievesGuild* lines. Had to add pDia09 conditions to those ratway lines to avoid them being said before the thieves guild lines mention the ratway.

Testing continues....

Comment #3 Apr 19, 2014 10:34 pm
DayDreamer said:
 
pDia07 is DialogueRiftenBlackBriarBranchTopic "Tell me about the Black-Briar family." [DIAL:000C3A18]

Serendipity! When I repurposed it for Keerava, it was to condition her Black-Briar rumors.

The reason that I hadn't found it was USKP removed the condition, as it wasn't set anywhere. (Where in the version history?) Found with TES5Edit instead of CK.

Will find the appropriate spots and fix them.

Comment #4 Apr 19, 2014 11:06 pm
DayDreamer said:
 
<a data-ipb='nomediaparse' href='http://www.afkmods.com/index.php?/files/file/1211-riften-dialogue-flags-fix/'>http://www.afkmods.com/index.php?/files/file/1211-riften-dialogue-flags-fix/</a>

Comment #5 Apr 20, 2014 2:55 am
DayDreamer said:
 
Version 2 also checks global DialogueRiftenScene01. Why they didn't just use a common interface....

Comment #6 Apr 20, 2014 2:11 pm
DayDreamer said:
 
Version 3 adds 24 hour timeout to Keerava's rumor list entries, so the dialogue topic disappears after all the current entries have been exhausted (like other innkeepers).

Made the top entry not random, as it sets the pDia07 flag.

Testing complete. I've tested in as many different orders as I can think of, Maul before Mjoll and vice versa, shopkeepers, stalls, etc. Seems to work now!

Comment #7 Apr 20, 2014 2:36 pm
Arthmoor said:
 
Fixed for USKP 2.0.4.

Comment #8 Apr 21, 2014 1:03 am
Showing Comments 1 - 8 of 8