 Issue Data
|
|
||||||||||||||||||||||||||||||
Issue #19884: Radroaches have incorrect names on rare occasions
If you still have that save it would probably be helpful 
There are four basic radroaches existing (legendary ones not included):
EncRadRoach
EncRadRoachNOSCALE
EncRadRoachGlowing
EncRadRoachGlowingNOSCALE
The NOSCALE variants have a fixed size, whereas the size of the "normal" ones is variable [NB: The size is part of the traits, as is the skin].
They are in separate leveled character lists;
LCharRadRoach:
- lvl 1: EncRadRoach
- lvl 10: EncRadRoach
- lvl 10: EncRadRoachGlowing
- lvl 20: EncRadRoach
- lvl 20: EncRadRoachGlowing
LCharRadRoachNOSCALE:
- lvl 1: EncRadRoachNOSCALE
- lvl 10: EncRadRoachNOSCALE
- lvl 10: EncRadRoachGlowingNOSCALE
- lvl 20: EncRadRoachNOSCALE
- lvl 20: EncRadRoachGlowingNOSCALE
Finally, there are two sorts of leveled radroaches, LvlRadRoach and LvlRadRoachNOSCALE. Most radroaches placed in the game world are LvlRadRoach type radroaches. LvlRadRoachNOSCALE type radroaches are used in a few places only, among them Revere Beach Station. The setup of LvlRadRoach is simple: it has everything templated on LCharRadRoach (except for the legendary template, of course). However, LvlRadRoachNOSCALE has a problem: it has the traits templated on LCharRadRoachNOSCALE. but everything else on LCharRadRoach. So, what happens if a LvlRadRoachNOSCALE type radroach is created from these templates ? The game takes everything from LCharRadRoach, including the base data (and these include the name). To do this, it picks one actor from LCharRadRoach and uses all properties of that actor that have the same template specified, i.e. it evaluates LCharRadRoach only once (unless you have the "Calc for each template" box ticked, but this isn't the case here). To pick the traits however, it has to evaluate another list, in this case LCharRadRoachNOSCALE (simply because it is another template) and there it finds both glowing radroaches and non-glowing ones. That is, irrespective of whether it picked a glowing radroach or a non-glowing one from LCharRadRoach (and uses the name of that pick already), it will combine them randomly with the traits picked from LCharRadRoachNOSCALE - and that's why the appearance may not match the names.
Fix is simple: instead of using LCharRadRoachNOSCALE only for the traits of LvlRadRoachNOSCALE, use it for everything.
EncRadRoach
EncRadRoachNOSCALE
EncRadRoachGlowing
EncRadRoachGlowingNOSCALE
The NOSCALE variants have a fixed size, whereas the size of the "normal" ones is variable [NB: The size is part of the traits, as is the skin].
They are in separate leveled character lists;
LCharRadRoach:
- lvl 1: EncRadRoach
- lvl 10: EncRadRoach
- lvl 10: EncRadRoachGlowing
- lvl 20: EncRadRoach
- lvl 20: EncRadRoachGlowing
LCharRadRoachNOSCALE:
- lvl 1: EncRadRoachNOSCALE
- lvl 10: EncRadRoachNOSCALE
- lvl 10: EncRadRoachGlowingNOSCALE
- lvl 20: EncRadRoachNOSCALE
- lvl 20: EncRadRoachGlowingNOSCALE
Finally, there are two sorts of leveled radroaches, LvlRadRoach and LvlRadRoachNOSCALE. Most radroaches placed in the game world are LvlRadRoach type radroaches. LvlRadRoachNOSCALE type radroaches are used in a few places only, among them Revere Beach Station. The setup of LvlRadRoach is simple: it has everything templated on LCharRadRoach (except for the legendary template, of course). However, LvlRadRoachNOSCALE has a problem: it has the traits templated on LCharRadRoachNOSCALE. but everything else on LCharRadRoach. So, what happens if a LvlRadRoachNOSCALE type radroach is created from these templates ? The game takes everything from LCharRadRoach, including the base data (and these include the name). To do this, it picks one actor from LCharRadRoach and uses all properties of that actor that have the same template specified, i.e. it evaluates LCharRadRoach only once (unless you have the "Calc for each template" box ticked, but this isn't the case here). To pick the traits however, it has to evaluate another list, in this case LCharRadRoachNOSCALE (simply because it is another template) and there it finds both glowing radroaches and non-glowing ones. That is, irrespective of whether it picked a glowing radroach or a non-glowing one from LCharRadRoach (and uses the name of that pick already), it will combine them randomly with the traits picked from LCharRadRoachNOSCALE - and that's why the appearance may not match the names.
Fix is simple: instead of using LCharRadRoachNOSCALE only for the traits of LvlRadRoachNOSCALE, use it for everything.
Comment #3 Apr 23, 2021 2:47 pm
Edited by Sclerocephalus on Apr 23, 2021 2:49 pm
Showing Comments 1 - 3 of 3