Unofficial Fallout 4 Patch

I think I can add something, which fits: Ada behaves different in every game, I think!

Ada at start has Protectron legs, and looks clumsy and is slow. So the first thing I always did in several playthroughs is parking her somewhere and continuing to play, until I find Assaultron legs in a robot encounter. Then I mount these on Ada, and she moves well. Sometimes too well...

Ada seems sometimes fast, but civilized, in my current game she is nearly unbearable, permanently walking around and talking without pause, always running in my line of fire, walking through dialog sequences, and so on. She is worse than Dogmeat. This was not always so. In other games she is fast, but behaves normal.

Could it be, that her combat parameters and behavior is uninitialized and random because of this? She is and was always very strong and deadly, this never changes. But her behavior changes.

I tried a mod, where you can set the distance of a companion. The mod just uses existing routines in the game to set these - it just was never implemented in the dialogues. But Piper and Cait behave completely different in this respect, so there are different combat behaviors.

Since I used the mod to set Adas distance to far, she behaves normally, even when I reset it to medium (which should be default) or even near.

This is not the reported bug, where you cannot talk to Ada after the first caravan battle, where you get to know her! This worked in all my games.

Also it is my impression, that working on Ada in the robot workbench can slightly change her behavior in combat and outside combat. But I may be mistaken...

I got the same error as in the original report, but also with line 340 (not just 339):

[12/19/2017 - 11:39:33PM] error: Cannot call GetValue() on a None object, aborting function call
stack:
[ (0100FF12)].companionactorscript.OnInit() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 340
[12/19/2017 - 11:39:33PM] warning: Assigning None to a non-object variable named "::temp17"
stack:
[ (0100FF12)].companionactorscript.OnInit() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 340

Also getting the errors below (something is obviously very wrong with Ada's companion script). If I should move this to a different ticket, let me know.

[01/17/2018 - 12:13:46AM] error: Cannot access an element of a None array
stack:
[ (0100FF12)].companionactorscript.GetNextThreshold() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1207
[ (0100FF12)].companionactorscript.TestValueForAffinityBump() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1655
[ (0100FF12)].companionactorscript.GetWithPlayerAffinityGain() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 300
[ (0100FF12)].companionactorscript.HandleWithPlayer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 684
[ (0100FF12)].companionactorscript.OnTimer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 426
[01/17/2018 - 12:13:46AM] error: Cannot access a variable of a None struct
stack:
[ (0100FF12)].companionactorscript.GetNextThreshold() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1207
[ (0100FF12)].companionactorscript.TestValueForAffinityBump() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1655
[ (0100FF12)].companionactorscript.GetWithPlayerAffinityGain() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 300
[ (0100FF12)].companionactorscript.HandleWithPlayer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 684
[ (0100FF12)].companionactorscript.OnTimer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 426
[01/17/2018 - 12:13:46AM] error: Cannot call GetValue() on a None object, aborting function call
stack:
[ (0100FF12)].companionactorscript.GetNextThreshold() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1207
[ (0100FF12)].companionactorscript.TestValueForAffinityBump() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1655
[ (0100FF12)].companionactorscript.GetWithPlayerAffinityGain() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 300
[ (0100FF12)].companionactorscript.HandleWithPlayer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 684
[ (0100FF12)].companionactorscript.OnTimer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 426
[01/17/2018 - 12:13:46AM] warning: Assigning None to a non-object variable named "::temp372"
stack:
[ (0100FF12)].companionactorscript.GetNextThreshold() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1207
[ (0100FF12)].companionactorscript.TestValueForAffinityBump() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1655
[ (0100FF12)].companionactorscript.GetWithPlayerAffinityGain() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 300
[ (0100FF12)].companionactorscript.HandleWithPlayer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 684
[ (0100FF12)].companionactorscript.OnTimer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 426
[01/17/2018 - 12:13:46AM] error: Cannot access an element of a None array
stack:
[ (0100FF12)].companionactorscript.GetNextThreshold() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1209
[ (0100FF12)].companionactorscript.TestValueForAffinityBump() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1655
[ (0100FF12)].companionactorscript.GetWithPlayerAffinityGain() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 300
[ (0100FF12)].companionactorscript.HandleWithPlayer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 684
[ (0100FF12)].companionactorscript.OnTimer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 426
[01/17/2018 - 12:13:46AM] error: Cannot access a variable of a None struct
stack:
[ (0100FF12)].companionactorscript.TestValueForAffinityBump() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1655
[ (0100FF12)].companionactorscript.GetWithPlayerAffinityGain() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 300
[ (0100FF12)].companionactorscript.HandleWithPlayer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 684
[ (0100FF12)].companionactorscript.OnTimer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 426
[01/17/2018 - 12:13:46AM] error: Cannot call GetValue() on a None object, aborting function call
stack:
[ (0100FF12)].companionactorscript.TestValueForAffinityBump() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1660
[ (0100FF12)].companionactorscript.GetWithPlayerAffinityGain() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 300
[ (0100FF12)].companionactorscript.HandleWithPlayer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 684
[ (0100FF12)].companionactorscript.OnTimer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 426
[01/17/2018 - 12:13:46AM] warning: Assigning None to a non-object variable named "ThresholdValue"
stack:
[ (0100FF12)].companionactorscript.TestValueForAffinityBump() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 1660
[ (0100FF12)].companionactorscript.GetWithPlayerAffinityGain() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 300
[ (0100FF12)].companionactorscript.HandleWithPlayer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 684
[ (0100FF12)].companionactorscript.OnTimer() - "C:\Users\Dr. Peter Haas\AppData\Local\Temp\PapyrusTemp\companionactorscript.psc" Line 426

As with the other Ada ticket like this, we have no idea what values are appropriate so we can't come up with proper substitutions. We'd be guessing at best and have no idea what the intent ever was with her.

A close inspection of the errors show that > 95% of the log spam comes from the TestValueForAffinityBump() and GetNextThreshold() functions. If i an error occurs in the latter function, it has always been called by the former function. Not a big surprise because TestValueForAffinityBump() tries to access an array that holds structs with all the globals that are missing on Ada. To put it short, Ada's ThresholdData_Array does not exist.

These functions run on a timer event, so are called in regular intervals and make the log spam pretty annoying. But there's also a fair bit of unnecessary script activity involved because all of the operations lead nowhere if the array doesn't exist.

Adding a check to the beginning of the TestValueForAffinityBump() function to bail out and return 'false' if said array does not exist This both eliminates the log spam and saves a fair bit of unnecessary script activity.