Below is attached a patch for about 90 conversation quests (Actor Dialogue event). It fixes the following issues:
- Wrong GetIsID conditions of the aliases that are filled from the event data, ranging from picking actors that do NOT take part in the scene to using "AND" when it should be "OR" or vice versa.
- Picking one entry from the event data twice, like putting "Actor 1" from the event data both to Actor1 and to Actor2 aliases.
- For scene setups more complex than two unique actors speaking (for example, if it's 3 actors in the scene or more than one option for a single speaker in the scene), not checking if the "complex" actors are anywhere nearby. I used the setup from the Corpulus/Sorex/Minnette conversations in the Winking Skeever as a template because in my experience they work far more reliably than, say, the 3-actor conversations in the Blue Palace.
- Inconsistent usage of "Allow Reuse in Quest" and "Allow Reserved" alias flags.
- Conversation scene missing "Begin On Quest Start" and "Stop Quest on End" flags.
This patch covers all the bugs mentioned in the following tickets I created in the past 2 days:
https://afktrack.afkmods.com/index.php?a=issues&i=35534
https://afktrack.afkmods.com/index.php?a=issues&i=35535
https://afktrack.afkmods.com/index.php?a=issues&i=35536
https://afktrack.afkmods.com/index.php?a=issues&i=35537
It also contains a bunch of extra fixes.
Note 1: xEdit shows edits of "Unknown 13" flag in some quests in the patch. It's not my initiative, it's entirely Creation Kit's fault. To be honest, I've no idea if these edits should be copied from the patch or ignored.
Note 2: the job of looking for the bugs wasn't done by me personally (as in checking all the 900-something dialogue quests one by one in CK), but by a "linter" (a script) I wrote for the task. This means that I caught all the specific weird things I told the script to look for, but it does not mean that there no other possible bugs left in them. This also means that the patch may accidentally bring to the game some unwanted stuff. For example, some of the Riften content touches heavily Haelga and her sex life, and Hemming Black-Briar trying to bed Wylandriah (DialogueRiftenKeepScene06Alternate), and perhaps Bethesda decided that it's too much and disabled it intentionally. I think some kind of second opinion or review is needed for the patch.