Adopting children can often fail to process fully due to some errors in how the scripting for it is handled. When adopting a child, there is a length series of checks that starts in the AdoptChild function on BYOHRelationshipAdoptionScript and ends with calling on a scheduler quest to move them to their new home.
Many of the issues are based on assumptions and sending incorrect variables through to various functions, and some assumptions that adoptions will only ever be carried out in the 5 original vanilla homes.
The BYOHRelationshipAdoptionNewAdoptionHandler quest seems to be at the root of many of these problems because it attempts to use a TravelMarker alias to bootstrap the location of where the child is being sent. If that's not one of the 5 original vanilla homes, this alias will fail to fill, causing the HomeLocation alias to fill as well. Instead, the HomeLocation should be filled first from an added parameter to the story event call that launches this quest using the actual location the child is being told to go to. This in turn required several edits to the BYOHRelationshipAdoptionScript to properly collect all the needed data for the move.
The fix has been tested and works correctly for any new child being adopted for the first time into vanilla homes, HF homes, and even the various Creation Club homes.
This same series of quests and scripts are also used to move an existing family from one home to another, which has also had issues with reliably completing itself.
Apparently these fixes may also have resolved long standing issues with Lucia and Sofie not completing the process as well even if it otherwise succeeded for the rest of the family.
Attached Files:
Adoption Fix.7z
Issue Data
Issue #35669: Adopting children is not always reliable with the non-vanilla homes.